Consolidate botocore usage in EMF and Sigv4 Exporters #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liustve
changed the title
srprash
reviewed
Jul 3, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_utils.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
srprash
reviewed
Jul 3, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
srprash
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR cleans up botocore usages in EMF and Sigv4 exporters and migrates them to the
_utilsclass.Added get_aws_session() function in _utils.py to handle botocore session creation
Refactored get_aws_region() to properly handle AWS_REGION and AWS_DEFAULT_REGION environment variables
Added IS_BOTOCORE_INSTALLED flag to prevent runtime errors for customers not using botocore-dependent features
Added _create_aws_otlp_exporter() function to prevent runtime errors from instantiating AWS OTLP exporter creation if the user does not have botocore installed
Changed OTLP log exporter to allow optional constructor parameters for
x-aws-log-groupandx-aws-log-streamheaders to consolidate it with EMF exporterForce flush race condition: Added force flush implementation to prevent race conditions in
AwsBatchLogRecordProcessoras here: #407By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.