Skip to content

Conversation

@lukeina2z
Copy link
Contributor

This PR updates the upstream OpenTelemetry Python dependency to its September 2025 release; Upgrading from version 1.33.1/0.54b1 to 1.37.0/0.58b0.

It also resolves several conflicts between the following OTel PRs and existing ADOT patches:

starlette: Remove maximum version constraint
open-telemetry/opentelemetry-python-contrib#3456

Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use
open-telemetry/opentelemetry-python#4562

Make exporter timeout encompass retries/backoffs, add jitter to backoffs, cleanup code a bit
open-telemetry/opentelemetry-python#4564

Update BatchSpanProcessor to use new BatchProcessor class
open-telemetry/opentelemetry-python#4580

Fix issue where deadlock can occur over logging._lock
open-telemetry/opentelemetry-python#4636

Tests Performed

tox -e lint
tox -e spellcheck
tox -e 3.9-test-aws-opentelemetry-distro
tox -e 3.10-test-aws-opentelemetry-distro
tox -e 3.11-test-aws-opentelemetry-distro
tox -e 3.12-test-aws-opentelemetry-distro
tox -e 3.13-test-aws-opentelemetry-distro

Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lukeina2z lukeina2z requested a review from a team as a code owner October 29, 2025 16:59
…58b0

This PR updates the upstream OpenTelemetry Python dependency to its September 2025 release, upgrading from version 1.33.1/0.54b1 to 1.37.0/0.58b0.

It also resolves several conflicts between the following OTel PRs and existing ADOT patches:

starlette: Remove maximum version constraint
open-telemetry/opentelemetry-python-contrib#3456

Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use
open-telemetry/opentelemetry-python#4562

Make exporter timeout encompass retries/backoffs, add jitter to backoffs, cleanup code a bit
open-telemetry/opentelemetry-python#4564

Update BatchSpanProcessor to use new BatchProcessor class
open-telemetry/opentelemetry-python#4580

Fix issue where deadlock can occur over logging._lock
open-telemetry/opentelemetry-python#4636

Tests Performed

tox -e lint
tox -e spellcheck
tox -e 3.9-test-aws-opentelemetry-distro
tox -e 3.10-test-aws-opentelemetry-distro
tox -e 3.11-test-aws-opentelemetry-distro
tox -e 3.12-test-aws-opentelemetry-distro
tox -e 3.13-test-aws-opentelemetry-distro

Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests
mxiamxia
mxiamxia previously approved these changes Oct 29, 2025
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

yiyuan-he
yiyuan-he previously approved these changes Oct 29, 2025
Copy link
Contributor

@yiyuan-he yiyuan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeina2z lukeina2z dismissed stale reviews from yiyuan-he and mxiamxia via d450044 October 30, 2025 02:11
@lukeina2z lukeina2z enabled auto-merge (squash) October 30, 2025 02:11
@lukeina2z lukeina2z disabled auto-merge October 30, 2025 15:16
@mxiamxia mxiamxia merged commit d3b22ba into aws-observability:main Oct 30, 2025
16 checks passed
@lukeina2z lukeina2z deleted the pr-to-3.17 branch October 30, 2025 16:58
lukeina2z added a commit to lukeina2z/aws-otel-python-instrumentation that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants