Skip to content

fix: Ensure AlwaysRecordSampler respects root sampling result attributes #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majanjua-amzn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Ensure AlwaysRecordSampler respects root sampling result attributes #594

majanjua-amzn wants to merge 2 commits into from

Conversation

@majanjua-amzn
Copy link
Contributor

@majanjua-amzn majanjua-amzn commented Jan 28, 2026 •
edited
Loading

Spec

AlwaysRecordSampler must:

  • Return root sampler's result directly if the sampling decision is RECORD_ONLY or RECORD_AND_SAMPLE
  • Return the root sampler's result with the sampling decision overwritten to RECORD_ONLY if the root sampler's decision is DROP. In this case, we must also respect the root sampler's modifications to the attributes, if any exist.

Testing

Added unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@majanjua-amzn majanjua-amzn requested a review from a team as a code owner January 28, 2026 20:23
@majanjua-amzn majanjua-amzn added bug Something isn't working python Pull requests that update Python code labels Jan 28, 2026
thpierce
thpierce reviewed Jan 28, 2026
View reviewed changes
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/always_record_sampler.py Outdated
return SamplingResult(
Decision.RECORD_ONLY,
attributes,
result.attributes,
Copy link
Contributor

@thpierce thpierce Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was intentionally NOT done: 4b36553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thpierce thpierce thpierce left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@majanjua-amzn @thpierce