ci: scope down GitHub Token permissions#726
Closed
AdnaneKhan wants to merge 1 commit intoaws-observability:mainfrom
Closed
ci: scope down GitHub Token permissions#726AdnaneKhan wants to merge 1 commit intoaws-observability:mainfrom
AdnaneKhan wants to merge 1 commit intoaws-observability:mainfrom
Conversation
williazz
requested changes
Dec 12, 2025
Collaborator
williazz
left a comment
There was a problem hiding this comment.
Thanks! Can you check the linting please?
Run npx prettier --check .
Checking formatting...
[warn] .github/workflows/codeql-analysis.yml
[warn] Code style issues found in the above file. Forgot to run Prettier?
Error: Process completed with exit code 1.
williazz
reviewed
Dec 12, 2025
| branches: [main] | ||
|
|
||
| permissions: | ||
| security-events: write |
Collaborator
There was a problem hiding this comment.
question: are we removing read permissions by only allowing security-events: write?
Contributor
Author
There was a problem hiding this comment.
For public repositories read permissions on the GitHub Token are not required because the endpoints work without any AuthN/AuthZ, with the exception of unique keys like models: read (for AI inference with GitHub models) and packages: read (for workflows that run container jobs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope Down GitHub Token Permissions
This PR updates GitHub Actions workflows to use minimal required permissions instead of the default elevated permissions.
Why This Matters
Following the principle of least privilege, workflows should only have the specific permissions they need to function.
Changes
This PR adds explicit
permissions:blocks to workflows that currently rely on default permissions, scoping them down to only what's required for their operations.Please review the changes to ensure the specified permissions match your workflow requirements.