chore: revert changes for disabling VirtualPageLoadTimer#750
Closed
ishajos wants to merge 1 commit intoaws-observability:mainfrom
Closed
chore: revert changes for disabling VirtualPageLoadTimer#750ishajos wants to merge 1 commit intoaws-observability:mainfrom
ishajos wants to merge 1 commit intoaws-observability:mainfrom
Conversation
limhjgrace
approved these changes
Jan 7, 2026
Contributor
limhjgrace
left a comment
limhjgrace
left a comment
There was a problem hiding this comment.
For context, these commits are being reverted given we want to reevaluate how we will rollout the fix/removal of the current VirtualPageLoadTimer given all scenarios will result in a breaking change to UX.
Collaborator
|
Instead of reverting, can we keep the configuration and set the default value to true? That way, impacted users can still opt-out while we finishing getting consensus on what to do about this broken feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes from these 2 commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.