Add liveness/readiness probe to operator deployment #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
/readyz
/healthz
The operator used/uses kubebuilder to create the operator. Kubebuilder did not include liveness/readiness probes for the deployment at the time the operator was created. In more recent versions, it is included: kubernetes-sigs/kubebuilder#1856. Just following the same pattern, i.e. path, port, initial delay seconds, period seconds.
Testing
Happy path
The deployment is in a
ready
state after the probe succeeds.Unhappy path
If you change the port/path to something incorrect, the Helm upgrade will fail with
you will also get this in the events for the deployment as well:
The deployment stays in a
not ready
state.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.