Skip to content

Set up dcgmexporter interval to 1000ms when accelerated_compute_gpu_metrics_collection_interval is present and less than 60 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set up dcgmexporter interval to 1000ms when accelerated_compute_gpu_metrics_collection_interval is present and less than 60 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions charts/amazon-cloudwatch-observability/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,26 @@ Get the current recommended neuron-monitor image for a region
{{- printf "%s/%s:%s" $imageDomain .Values.neuronMonitor.image.repository .Values.neuronMonitor.image.tag -}}
{{- end -}}

{{/*
Set DCGM_EXPORTER_INTERVAL environment variable for dcgmExporter if accelerated_compute_gpu_metrics_collection_interval is set and less than 60
*/}}
{{- define "dcgm-exporter.env" -}}
{{- $intervalFound := false -}}
{{- $intervalValue := 0 -}}
{{- range .Values.agents -}}
{{- $agent := merge . (deepCopy $.Values.agent) -}}
{{- $agentConfig := $agent.config | default $agent.defaultConfig -}}
{{- if and (hasKey $agentConfig "logs") (hasKey $agentConfig.logs "metrics_collected") (hasKey $agentConfig.logs.metrics_collected "kubernetes") (hasKey $agentConfig.logs.metrics_collected.kubernetes "accelerated_compute_gpu_metrics_collection_interval") -}}
{{- $intervalFound = true -}}
{{- $intervalValue = $agentConfig.logs.metrics_collected.kubernetes.accelerated_compute_gpu_metrics_collection_interval -}}
{{- end -}}
{{- end -}}
{{- if and $intervalFound (lt ($intervalValue | int) 60) -}}
- name: DCGM_EXPORTER_INTERVAL
value: "1000"
{{- end -}}
{{- end -}}

{{/*
Get the current recommended auto instrumentation java image
*/}}
Expand Down Expand Up @@ -407,5 +427,3 @@ Get namespaceSelector value for admission webhooks
{{- end -}}
{{- end -}}
{{- end -}}


3 changes: 2 additions & 1 deletion charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: spec.nodeName
{{- include "dcgm-exporter.env" . | nindent 2 }}
ports:
- name: "metrics"
port: {{ .Values.dcgmExporter.service.port }}
Expand Down Expand Up @@ -69,4 +70,4 @@ spec:
cert_file: /etc/amazon-cloudwatch-observability-dcgm-cert/server.crt
key_file: /etc/amazon-cloudwatch-observability-dcgm-cert/server.key
{{- dict "component" .Values.dcgmExporter "context" . | include "amazon-cloudwatch-observability.common.tolerations" | nindent 2 }}
{{- end }}
{{- end }}