Move args into command and add neuron-monitor-blocker volume #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The current way to pass args via NeuronMonitor crd is problematic. It will causes the neuron-monitor daemonset pod to be immediately terminated after launch, recreated, and then go through a couple of these cycles before finally reaching a RUNNING state.
Update the neuron-monitor pod image from version
1.6.0to1.7.0. Note that neuron-monitor 1.7.0 has NOT been released yet, so pls don't merge this PR until it is releasedAdd
neuron-monitor-blockervolume as an additional readonly volume mount in the neuron-monitor pod.Description of changes:
neuron-monitor daemonset manifest :
Removed
argsfield and merged it to a unifiedcommandfield with all the argsUpdated the neuron-monitor version tag from
1.6.0to1.7.0Add the
neuron-monitor-blockervolume and volume mountBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.