Skip to content

refactor(test): make CORS test consistent with expected behavior #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2024
Merged

refactor(test): make CORS test consistent with expected behavior #4882

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
946a620
fix: cors is opt out if enabled
tonnico Aug 3, 2024
1f5d2c9
Merge branch 'develop' into fix-cors-test
leandrodamascena Aug 4, 2024
0ba6cbf
Merge branch 'develop' into fix-cors-test
leandrodamascena Aug 5, 2024
d6386b8
test: opt-out instead opt-in for cors endpoints
tonnico Aug 5, 2024
ac74e4d
test: catch some UserWarnings
tonnico Aug 5, 2024
792779c
Merge branch 'develop' into fix-cors-test
leandrodamascena Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tests/functional/event_handler/required_dependencies/test_api_gateway.py
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low hanging fruit to test the UserWarnings and reduce noise in the pytest output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great attention to details @wurstnase! Thank you so much!! ❤️

Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,8 @@ def raises_error():
def test_powertools_dev_sets_debug_mode(monkeypatch):
# GIVEN a debug mode environment variable is set
monkeypatch.setenv(constants.POWERTOOLS_DEV_ENV, "true")
app = ApiGatewayResolver()
with pytest.warns(UserWarning, match="POWERTOOLS_DEV environment variable is enabled."):
app = ApiGatewayResolver()

# WHEN calling app._debug
# THEN the debug mode is enabled
Expand Down Expand Up @@ -1428,7 +1429,8 @@ def get_func():
def get_func_another_duplicate():
raise RuntimeError()

app.include_router(router)
with pytest.warns(UserWarning, match="A route like this was already registered"):
app.include_router(router)

# WHEN calling the handler
result = app(LOAD_GW_EVENT, None)
Expand Down Expand Up @@ -1707,7 +1709,12 @@ def my_path():
@event_source(data_class=APIGatewayProxyEventV2)
def handler(event: APIGatewayProxyEventV2, context):
assert isinstance(event, APIGatewayProxyEventV2)
return app.resolve(event, context)

with pytest.warns(
UserWarning,
match="You don't need to serialize event to Event Source Data Class when using Event Handler",
):
return app.resolve(event, context)

# THEN
result = handler(load_event("apiGatewayProxyV2Event.json"), None)
Expand Down