generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 455
feat(event_handler): add support for externalDocs attribute in OpenAPI schema #6945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leandrodamascena
merged 7 commits into
aws-powertools:develop
from
mhindery:external_documentation
Jul 4, 2025
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0b2f19e
Add top-level externalDocs support
f790623
add formal test
f7bdfa7
Merge branch 'develop' into external_documentation
leandrodamascena 911e300
cleanup import
ef62f8a
Merge branch 'develop' into external_documentation
leandrodamascena 1888d84
Update aws_lambda_powertools/event_handler/api_gateway.py
mhindery 29cc623
Fix test
leandrodamascena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
tests/functional/event_handler/_pydantic/test_openapi_external_documentation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
from __future__ import annotations | ||
|
||
from aws_lambda_powertools.event_handler.api_gateway import APIGatewayRestResolver | ||
from aws_lambda_powertools.event_handler.openapi.models import ExternalDocumentation, Server | ||
mhindery marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
|
||
def test_openapi_schema_no_external_documentation(): | ||
app = APIGatewayRestResolver() | ||
|
||
schema = app.get_openapi_schema(title="Hello API", version="1.0.0") | ||
assert not schema.externalDocs | ||
|
||
|
||
def test_openapi_schema_external_documentation(): | ||
app = APIGatewayRestResolver() | ||
|
||
schema = app.get_openapi_schema( | ||
title="Hello API", | ||
version="1.0.0", | ||
external_documentation=ExternalDocumentation( | ||
description="Find out more about this API", | ||
url="https://example.org/docs", | ||
), | ||
) | ||
|
||
assert schema.externalDocs | ||
assert schema.externalDocs.description == "Find out more about this API" | ||
assert schema.externalDocs.url == "https://example.org/docs" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.