Skip to content

docs(logger): fix typo in sampling examples #7133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trevmt
Copy link
Contributor

@trevmt trevmt commented Aug 7, 2025

Issue number: #7131
Closes #7131

Summary

Fixed the sampling example code present in the documentation regarding sampling.

Changes

Changed sample_rate to sampling_rate on line 5 in both sampling_debug_logs_with_standalone_function.py and sampling_debug_logs_with_decorator.py.

User experience

User's now have access to accurate example code in the sampling section of the documentation.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change? No

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@trevmt trevmt requested a review from a team as a code owner August 7, 2025 00:49
@trevmt trevmt requested a review from anafalcao August 7, 2025 00:49
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2025
Copy link

boring-cyborg bot commented Aug 7, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@trevmt trevmt mentioned this pull request Aug 7, 2025
1 task
@leandrodamascena leandrodamascena changed the title Fixed sampling examples, changed sample_rate to sampling_rate docs(logger): fix typo in sampling examples Aug 7, 2025
@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for anafalcao August 7, 2025 07:10
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 7, 2025
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @trevmt thanks a lot for working on this!

APPROVED!

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.35%. Comparing base (7d67307) to head (30d2b55).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7133   +/-   ##
========================================
  Coverage    96.35%   96.35%           
========================================
  Files          275      275           
  Lines        12980    12980           
  Branches       965      965           
========================================
  Hits         12507    12507           
  Misses         366      366           
  Partials       107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Aug 7, 2025

@leandrodamascena leandrodamascena merged commit 64af21e into aws-powertools:develop Aug 7, 2025
15 checks passed
Copy link

boring-cyborg bot commented Aug 7, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Issue in Sampling example
2 participants