Skip to content

improv(maintenance): Removed some unused assignments and added missing error handling #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025
Merged

improv(maintenance): Removed some unused assignments and added missing error handling #4208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
076a597
Removed some unused assignments and added an error log to an unhandle…
sdangol Jul 24, 2025
0436a23
Removed underscore in error variable
sdangol Jul 24, 2025
03592e7
Merge branch 'main' into improv/unused-code
svozza Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/snippets/parameters/testingYourCodeClientHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export const handler = async (
return {
value: parameter,
};
} catch (_error) {
} catch (error) {
console.error('Unable to retrieve secret: ', error);
return {
message: 'Unable to retrieve secret',
};
Expand Down
6 changes: 0 additions & 6 deletions packages/parameters/tests/unit/BaseProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,6 @@ describe('Function: clearCaches', () => {
describe('Class: GetOptions', () => {
it('sets the default maxAge when not provided', () => {
// Prepare
const envVarsService = {
getParametersMaxAge: vi.fn(),
};
const options = new GetOptions();

// Assess
Expand All @@ -559,9 +556,6 @@ describe('Class: GetOptions', () => {
describe('Class: GetMultipleOptions', () => {
it('sets throwOnTransformError to false when not provided', () => {
// Prepare
const envVarsService = {
getParametersMaxAge: vi.fn(),
};
const options = new GetMultipleOptions();

// Assess
Expand Down
Loading