Skip to content

fix(tracer): pass args of decorated method as they are #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix(tracer): pass args of decorated method as they are #4312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/tracer/src/Tracer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,12 @@ class Tracer extends Utility implements TracerInterface {
const tracerRef = this;
// Use a function() {} instead of an () => {} arrow function so that we can
// access `myClass` as `this` in a decorated `myClass.myMethod()`.
descriptor.value = function (this: Handler, event, context, callback) {
descriptor.value = function (
this: Handler,
...args: Parameters<Handler>
) {
if (!tracerRef.isTracingEnabled()) {
return originalMethod.apply(this, [event, context, callback]);
return originalMethod.apply(this, args);
}

return tracerRef.provider.captureAsyncFunc(
Expand All @@ -440,11 +443,7 @@ class Tracer extends Utility implements TracerInterface {
tracerRef.addServiceNameAnnotation();
let result: unknown;
try {
result = await originalMethod.apply(this, [
event,
context,
callback,
]);
result = await originalMethod.apply(this, args);
if (options?.captureResponse ?? true) {
tracerRef.addResponseAsMetadata(result, process.env._HANDLER);
}
Expand Down