Skip to content

improv(ci): removed the secret inheritance and replaced with the needed secrets #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2025
Merged

improv(ci): removed the secret inheritance and replaced with the needed secrets #4364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da12016
Removed the secret inheritance and replaced with the needed secrets
sdangol Aug 21, 2025
7fdfedf
Removed passing GITHUB_TOKEN as it would be available by default in t…
sdangol Aug 21, 2025
2fb1d5e
Restored the Github token secret but using a different secret name
sdangol Aug 22, 2025
40342ff
Renamed the TOKEN secret to TOKEN_GITHUB
sdangol Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/make-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ jobs:
# publish_layer -> reusable_deploy_layer_stack -> reusable_update_layer_arn_docs
publish_layer:
needs: publish-npm
secrets: inherit
secrets:
AWS_LAYERS_BETA_ROLE_ARN: ${{ secrets.AWS_LAYERS_BETA_ROLE_ARN }}
AWS_LAYERS_PROD_ROLE_ARN: ${{ secrets.AWS_LAYERS_PROD_ROLE_ARN }}
TOKEN_GITHUB: ${{ secrets.GITHUB_TOKEN }}
permissions:
id-token: write
contents: write
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/on_doc_merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ jobs:
permissions:
id-token: write # trade JWT token for AWS credentials in AWS Docs account
contents: read # read from this repo to publish docs
secrets: inherit
secrets:
AWS_DOCS_ROLE_ARN: ${{ secrets.AWS_DOCS_ROLE_ARN }}
AWS_DOCS_BUCKET: ${{ secrets.AWS_DOCS_BUCKET }}
uses: ./.github/workflows/reusable_publish_docs.yml
with:
version: main
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/publish_layer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ on:
required: true

workflow_call:
secrets:
AWS_LAYERS_BETA_ROLE_ARN:
description: "Role ARN for deploying the Layer to Beta"
AWS_LAYERS_PROD_ROLE_ARN:
description: "Role ARN for deploying the Layer to Prod"
TOKEN_GITHUB:
description: "GitHub Token to interact with GitHub"
inputs:
latest_published_version:
type: string
Expand Down Expand Up @@ -117,4 +124,4 @@ jobs:
with:
temp_branch_prefix: 'ci-layer-docs'
pull_request_title: 'chore(ci): update layer ARN on documentation'
github_token: ${{ secrets.GITHUB_TOKEN }}
github_token: ${{ secrets.TOKEN_GITHUB }}
4 changes: 3 additions & 1 deletion .github/workflows/rebuild_latest_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ jobs:
permissions:
id-token: write # trade JWT token for AWS credentials in AWS Docs account
contents: read # read from this repo to publish docs
secrets: inherit
secrets:
AWS_DOCS_ROLE_ARN: ${{ secrets.AWS_DOCS_ROLE_ARN }}
AWS_DOCS_BUCKET: ${{ secrets.AWS_DOCS_BUCKET }}
uses: ./.github/workflows/reusable_publish_docs.yml
with:
version: ${{ inputs.latest_published_version }}
Expand Down
Loading