Skip to content

improv(tests): fixed the logger test breaking with Nodejs v22.19.0 #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

improv(tests): fixed the logger test breaking with Nodejs v22.19.0 #4410

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb5606
Changed the formatter test to match the error object instead of deep …
sdangol Sep 3, 2025
1a10ef5
Added the missing property instead of relaxing the checking
sdangol Sep 3, 2025
86f14b4
Added a conditional check to add the diff property only with node ver…
sdangol Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/logger/tests/unit/formatters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ describe('Formatters', () => {
const formattedError = formatter.formatError(error);

// Assess
expect(formattedError).toEqual({
expect(formattedError).toMatchObject({
stack: expect.arrayContaining([
expect.stringMatching(fileNameRegexpWithLine),
]),
Expand Down
Loading