-
Notifications
You must be signed in to change notification settings - Fork 175
fix(event-handler): fixed CORS behaviour not aligned with CORS spec #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ools-lambda-typescript into bug/cors-behaviour
@sdangol can you try to simplify the function a bit further? SonarCloud is reporting a higher than normal complexity. I see that there are two instances where we check Alternatively, even though in previous iterations we consolidated everything in its body, now that it has grown maybe we do need to split some parts. |
…ools-lambda-typescript into bug/cors-behaviour
Almost there :D |
|
Summary
This PR fixes some of the bugs that were introduced in the CORS middleware
Changes
Issue number: closes #4509
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.