Skip to content

docs(idempotency): fix dataKeywordArgument reference and remove unused test code #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2025
Merged

docs(idempotency): fix dataKeywordArgument reference and remove unused test code #4537

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
222d7ce
docs: replace dataKeywordArgument for eventKeyJmesPath use to access …
Sep 23, 2025
e54c0e8
test: remove non-existent dataKeywordArgument field
Sep 23, 2025
92838d6
docs: explain the distinction between eventKeyJmesPath and dataIndexA…
Sep 24, 2025
9ec4b6f
Merge branch 'main' into docs/remove-dataKeywordArgument
dreamorosi Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/idempotency/src/makeIdempotent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ const isOptionsWithDataIndexArgument = (
* // we use wrapper to make processing function idempotent with DynamoDBPersistenceLayer
* const processIdempotently = makeIdempotent(processRecord, {
* persistenceStore: new DynamoDBPersistenceLayer()
* dataKeywordArgument: 'transactionId', // keyword argument to hash the payload and the result
* config: new IdempotencyConfig({
* eventKeyJmesPath: 'transactionId', // this will use `transactionId` argument as idempotency payload
* }),
* });
*
* export const handler = async (
Expand Down
1 change: 0 additions & 1 deletion packages/idempotency/tests/unit/IdempotencyHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const mockFunctionPayloadToBeHashed = {};
const persistenceStore = new PersistenceLayerTestClass();
const mockIdempotencyOptions = {
persistenceStore,
dataKeywordArgument: 'testKeywordArgument',
config: new IdempotencyConfig({}),
};

Expand Down
Loading