Skip to content

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR resolves all the linting issues resulting from the new rules being introduced in #4545.

Note that I created a dedicated biome.json configuration that extends the root one to disable the noAwait rule which requires you to use the await keyword within an async function, or remove the async from the function.

This is generally desirable, however in our code snippets we purposefully leave most of the function's body empty to focus on the Powertools for AWS utilities, which means we can't always add some async operation just to satisfy the linter.

In this case I'm making an exception and prioritizing DX over correctness of the linter. Let me know if you disagree.

Important

This PR is expected to have failing CI, focus only on the CI steps for this package (examples/snippets). It's safe to merge since it's not going on main but on ci/fix_linting.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4562


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Sep 25, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Sep 25, 2025

Not all issues are linked correctly.

Please link each issue to the PR either manually or using a closing keyword in the format fixes #<issue-number> format.

If mentioning more than one issue, separate them with commas: i.e. fixes #<issue-number-1>, closes #<issue-number-2>.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 25, 2025
@dreamorosi dreamorosi linked an issue Sep 25, 2025 that may be closed by this pull request
2 tasks
Copy link

Copy link
Contributor

@sdangol sdangol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Agree with disabling the rule for this package since it's only the code snippets. There will probably be an async operation when actually using the snippet

@dreamorosi dreamorosi merged commit 9f45ef3 into ci/fix_linting Sep 25, 2025
36 of 40 checks passed
@dreamorosi dreamorosi deleted the style/examples_snippets branch September 25, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/L PRs between 100-499 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: fix linting issues for examples/snippets package

2 participants