style(docs): apply stricter linting #4574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR resolves all the linting issues resulting from the new rules being introduced in #4545.
Note that I created a dedicated
biome.json
configuration that extends the root one to disable thenoAwait
rule which requires you to use theawait
keyword within anasync
function, or remove theasync
from the function.This is generally desirable, however in our code snippets we purposefully leave most of the function's body empty to focus on the Powertools for AWS utilities, which means we can't always add some async operation just to satisfy the linter.
In this case I'm making an exception and prioritizing DX over correctness of the linter. Let me know if you disagree.
Important
This PR is expected to have failing CI, focus only on the CI steps for this package (
examples/snippets
). It's safe to merge since it's not going onmain
but onci/fix_linting
.Issue number: closes #4562
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.