Skip to content

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Sep 26, 2025

Summary

This PR adds the feature to support catch all routes in the Event Handler.

Changes

Please provide a summary of what's being changed

  • Added a regexRoutes property to store routes with regex
  • Updated the register function to register the route to regexRoutes if the path had any non-alphanumeric characters except for /, - or :
  • Updated the resolve function to match for the regexRoutes in the order of their registration.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4579


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Sep 26, 2025
@sdangol sdangol self-assigned this Sep 26, 2025
@boring-cyborg boring-cyborg bot added event-handler This item relates to the Event Handler Utility tests PRs that add or change tests labels Sep 26, 2025
@leandrodamascena
Copy link
Contributor

I'll review this in the next few minutes.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left some few comments.

@boring-cyborg boring-cyborg bot added the commons This item relates to the Commons Utility label Sep 30, 2025
@leandrodamascena
Copy link
Contributor

I'll review this PR by EOD.

@dreamorosi dreamorosi removed their request for review October 1, 2025 09:40
Copy link

sonarqubecloud bot commented Oct 3, 2025

@dreamorosi dreamorosi merged commit 19786bf into main Oct 3, 2025
37 checks passed
@dreamorosi dreamorosi deleted the feat/catch-all-route branch October 3, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commons This item relates to the Commons Utility event-handler This item relates to the Event Handler Utility size/L PRs between 100-499 LOC tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Support for a catch all route in Event Handler REST API

4 participants