-
Notifications
You must be signed in to change notification settings - Fork 175
feat(event-handler): add streaming functionality #4586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7a15cc4
to
da7abb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR - I'll need a day or two to review and test it.
Looking forward to streaming!
da7abb3
to
aee4058
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few minor comments and questions
packages/event-handler/tests/unit/rest/Router/middleware.test.ts
Outdated
Show resolved
Hide resolved
d44f4e4
to
e9c29d3
Compare
e9c29d3
to
df92e5d
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, this is really nice.
We should write a small short blog post on Builder Hub about this.
Summary
This PR adds the logic for returning streaming HTTP responses as currently supported by Lambda Function URLs. As event-handler does not currently support Function URLs, we are not exposing the final
streamify
function that users will use to enable streaming:This means that we will not have to have a long lived branch with the logic for this feature while we wait on Function URL support.
Changes
resolveStream
method that takes a LambdaResponseStream
as one of its argumentsAPIGatewayProxyResult
type.resolveStream
method and assoicated helper functions.Issue number: closes #4476
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.