fix(idempotency): Update durableExecutionMode string #4837
Merged
+328
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The durableExecutionMode property updated it's value types. This commit uses the correct value
boring-cyborg
bot
added
the
idempotency
svozza
reviewed
Dec 2, 2025
pull-request-size
bot
added
size/XL
Contributor
Author
|
My pre-commit has clobbered the formatting for the file. I added two tests to the end of the |
Contributor
Author
|
#4839 - Task for adding E2E tests |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Idempotency utility uses the
DurableContext.durableExecutionModevalue to determine if a function is replaying or executing. This allows us to discriminate between duplicate invokes (bad), and replays of the same function (good).The value of the string changed, from
REPLAY_MODEtoReplayMode. The earlier PR #4834 didn't work, as it would never see the expected string.Changes
Check for
ReplayModeinstead ofREPLAY_MODEThere also seems to be some formatting changes - I'm not sure why these didn't format correctly in the staging environment.
Issue number: closes #4831 (again)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.