This is a great addition. We also need more units. Good to go as is, but it might be worth separating units out into a separate message because that could (and should) get larger. I would also like to see some naming conventions so that we can scale the units in an organized fashion.

This is a great addition. We also need more units. Good to go as is, but it might be worth separating units out into a separate message because that could (and should) get larger. I would also like to see some naming conventions so that we can scale the units in an organized fashion.

Hi Austin, I have made a separate msg file for units as you suggested and added a few units and organised them. Please have a look at it and suggest any changes if require.
Also, will I be able to see these units on cloudwatch console through my custom metrics?

Also, will I be able to see these units on cloudwatch console through my custom metrics?

I would recommend testing this feature and demonstrating the output as part of the review process, which would answer your last question :-).

Hello @dabonnie, here's a screenshot of the error that I get when I launch the metric collector node with this custom message in use. And also I didn't get any data on cloudwatch console using this.

@mm318 @emersonknapp @jikawa-az

I'm sorry, I can't read screenshots - can you copy-paste any log output into a code block?

I'm sorry, I can't read screenshots - can you copy-paste any log output into a code block?

Hi @emersonknapp, this is the log output of error

[ WARN] [1616477742.231983343]: [EnumParseOverflowContainer] Encountered enum member watt which is not modeled in your clients. You should update your clients when you get a chance.
[ WARN] [1616477742.290441414]: [AWSErrorMarshaller] Encountered AWSError 'InvalidParameterValue': The parameter MetricData.member.7.Unit must be a value in the set [ Seconds, Microseconds, Milliseconds, Bytes, Kilobytes, Megabytes, Gigabytes, Terabytes, Bits, Kilobits, Megabits, Gigabits, Terabits, Percent, Count, Bytes/Second, Kilobytes/Second, Megabytes/Second, Gigabytes/Second, Terabytes/Second, Bits/Second, Kilobits/Second, Megabits/Second, Gigabits/Second, Terabits/Second, Count/Second, None ].
[ERROR] [1616477742.290639590]: [AWSClient] HTTP response code: 400
Exception name: InvalidParameterValue
Error message: The parameter MetricData.member.7.Unit must be a value in the set [ Seconds, Microseconds, Milliseconds, Bytes, Kilobytes, Megabytes, Gigabytes, Terabytes, Bits, Kilobits, Megabits, Gigabits, Terabits, Percent, Count, Bytes/Second, Kilobytes/Second, Megabytes/Second, Gigabytes/Second, Terabytes/Second, Bits/Second, Kilobits/Second, Megabits/Second, Gigabits/Second, Terabits/Second, Count/Second, None ].
5 response headers:
connection : close
content-length : 665
content-type : text/xml
date : Tue, 23 Mar 2021 05:35:41 GMT
x-amzn-requestid : de69125d-5adf-453c-8f16-5373f5471ccb
[ WARN] [1616477742.290797818]: [AWSClient] If the signature check failed. This could be because of a time skew. Attempting to adjust the signer.

The current set of metrics supported by this package are the ones laid out in the AWS CloudWatch documentation - https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html

The mapping between the MetricData and the AWS C++ SDK values (which themselves map to the strings from the documentation) happens in metric_object.h

The error message you're getting is from the following line, which cannot find a standard unit for the name "watt".

    datum.SetUnit(Aws::CloudWatch::Model::StandardUnitMapper::GetStandardUnitForName(unit_name));

Given this information, we have two choices:

1. Do not introduce new unit names, considering they cannot be understood by AWS CloudWatch
2. Introduce the new unit names, but explicitly map them to None for reporting to AWS CloudWatch. This allows the MetricData message to at least have this extra information, though it will not be represented on the cloud side.

The current set of metrics supported by this package are the ones laid out in the AWS CloudWatch documentation - https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html

The mapping between the MetricData and the AWS C++ SDK values (which themselves map to the strings from the documentation) happens in metric_object.h

The error message you're getting is from the following line, which cannot find a standard unit for the name "watt".

    datum.SetUnit(Aws::CloudWatch::Model::StandardUnitMapper::GetStandardUnitForName(unit_name));

Given this information, we have two choices:

1. Do not introduce new unit names, considering they cannot be understood by AWS CloudWatch
2. Introduce the new unit names, but explicitly map them to None for reporting to AWS CloudWatch. This allows the MetricData message to at least have this extra information, though it will not be represented on the cloud side.

Thanks for the updates. I will look into it.