Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Nov 18, 2020

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes #55

Copy link
Contributor

@dabonnie dabonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fran6co, thanks for the PR! You'll want to fix the build failures noted on the Travis builds.

@fran6co
Copy link
Contributor Author

fran6co commented Feb 1, 2021

Not sure why the test is failing with a segmentation fault

@dabonnie
Copy link
Contributor

dabonnie commented Feb 2, 2021

FYI @emersonknapp @mm318.

I may be misremembering, but thought utils-common was stuck at 1.6 for Lex and Polly breaking changes. Thoughts on this PR?

@mm318
Copy link
Contributor

mm318 commented Feb 2, 2021

I do remember there needed to be code changes to the Lex Cloud Extension when updating between some AWS SDK versions, and I think we've already done that once before. It may apply to this new AWS SDK version bump as well.

These particular Build & Test failures are unrelated to breaking changes to downstream dependencies though. However, bumping the AWS SDK version should involve some testing of downstream dependencies though.

@fran6co
Copy link
Contributor Author

fran6co commented Feb 2, 2021

The main reason I did this PR is for porting the ROS packages to 20.04 and noetic. I only had to fix this other project -> aws-robotics/utils-ros1#36 for it to work

@fran6co
Copy link
Contributor Author

fran6co commented Feb 10, 2021

Not sure why the test is failing with a segmentation fault

fixed segfault

@jikawa-az
Copy link
Contributor

Following up on this, updated branch and retesting.

@jikawa-az
Copy link
Contributor

@emersonknapp PTAL as well, this PR should add support for Focal which is not working for our images.

@jikawa-az jikawa-az merged commit 8d57717 into aws-robotics:master Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release aws_common (aka utils-common) into ROS Noetic?
5 participants