-
Notifications
You must be signed in to change notification settings - Fork 20
Update AWS SDK, fixed GCC 9 on ubuntu 20.04 #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fran6co, thanks for the PR! You'll want to fix the build failures noted on the Travis builds.
Not sure why the test is failing with a segmentation fault |
FYI @emersonknapp @mm318. I may be misremembering, but thought |
I do remember there needed to be code changes to the Lex Cloud Extension when updating between some AWS SDK versions, and I think we've already done that once before. It may apply to this new AWS SDK version bump as well. These particular |
The main reason I did this PR is for porting the ROS packages to 20.04 and noetic. I only had to fix this other project -> aws-robotics/utils-ros1#36 for it to work |
fixed segfault |
Following up on this, updated branch and retesting. |
@emersonknapp PTAL as well, this PR should add support for Focal which is not working for our images. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes #55