Add fragmentmetadata to the kvsappcli application, CI, fix build and runtime issues for Mac#90
Merged
sirknightj merged 5 commits intomainfrom Apr 30, 2025
Merged
Conversation
sirknightj
commented
Apr 24, 2025
| LogError("Invalid argument"); | ||
| /* Propagate the res error */ | ||
| } | ||
| else if ((res = getTimeInIso8601(pcXAmzDate, sizeof(pcXAmzDate))) != KVS_ERRNO_NONE) |
Contributor
Author
There was a problem hiding this comment.
Note for reviewers - this section, I wanted to add these two log lines:
LogInfo("Making describe request to: %s", pServPara->pcHost);
LogInfo("Stream name: %s", pDescPara->pcStreamName);
But, LogInfo doesn't return anything, so I couldn't put it in the condition. Therefore, I moved it to the else and moved the rest of the conditions into the else as well (indent).
sirknightj
commented
Apr 24, 2025
| { | ||
| if (puHttpStatusCode != NULL) | ||
| LogInfo("Making describe request to: %s", pServPara->pcHost); | ||
| LogInfo("Stream name: %s", pDescPara->pcStreamName); |
Contributor
Author
There was a problem hiding this comment.
Here is the change. The rest of this section remains untouched.
unicornss
reviewed
Apr 25, 2025
… add some more logs
unicornss
approved these changes
Apr 25, 2025
stefankiesz
reviewed
Apr 29, 2025
stefankiesz
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
kvsappcliapplication.KvsAppstruct.kvsappcliapplication so it builds out of the box for Mac.kvsappclifor a short time, verify clean exit, and verify fragment metadata was added.Build issues addressed
constcompile issue in media interfaceRuntime issues addressed
I encountered one additional issue where when building for Release, it won't connect due to SSL verification error. The current workaround I'm using is to build with Debug. I observed disabling the compiler optimizations works as well, though not ideal.
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.