Skip to content

Commit c2f446d

Browse files
author
Sebastian Schürmann
committed
refactor: move dataset name to a static
1 parent 8723558 commit c2f446d

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

typescript/quicksight/lib/quicksight-example-stack.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ export class QuicksightExampleStack extends Stack {
2424
public static QUICKSIGHT_SERVICE_ROLE = 'aws-quicksight-service-role-v0';
2525

2626

27+
public static QUICKSIGHT_DATASET_NAME = 'quicksightExampleDataset';
28+
29+
2730
constructor(scope: Construct, id: string, props?: StackProps) {
2831
super(scope, id, props);
2932

@@ -179,16 +182,16 @@ export class QuicksightExampleStack extends Stack {
179182
dataTransforms
180183
}
181184

182-
const datasetName = 'quicksightExampleDataset';
185+
183186
new CfnDataSet(
184187
this,
185-
datasetName,
188+
QuicksightExampleStack.QUICKSIGHT_DATASET_NAME,
186189
{
187190
awsAccountId: this.account,
188191
physicalTableMap: {[QuicksightExampleStack.QUICKSIGHT_DATASOURCE_NAME]: physicalTableProperties},
189192
logicalTableMap: {[QuicksightExampleStack.QUICKSIGHT_DATASOURCE_NAME]: logicalTableProperties},
190-
name: datasetName,
191-
dataSetId: datasetName,
193+
name: QuicksightExampleStack.QUICKSIGHT_DATASET_NAME,
194+
dataSetId: QuicksightExampleStack.QUICKSIGHT_DATASET_NAME,
192195
permissions: quicksightDatasetPermissions,
193196
importMode: 'SPICE'
194197
}

0 commit comments

Comments
 (0)