Skip to content

Conversation

@SGhotra1
Copy link
Contributor

This PR adds a TypeScript Example for setting up a Quicksight dataset and the resources needed to do so.
This can then be used in Quicksight to create an analysis of the provided world population data.

This example has been created during Pair programming and worked on by: @carreque @KathiHae @sebs @SGhotra1


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@kaiz-io kaiz-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple items

@SGhotra1 SGhotra1 requested a review from kaiz-io October 15, 2024 07:36
@sebs
Copy link
Contributor

sebs commented Oct 22, 2024

@kaiz-io Anything for us to do here. Not sure about the state of this PR. I have a hard time figuring out what is left to do.

Copy link
Contributor

@kaiz-io kaiz-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Just add a file the root of you project called DO_NOT_AUTOTEST. Does not need any file content.

Copy link
Contributor

@kaiz-io kaiz-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add DO_NOT_AUTOTEST to the root of your project. (same level as cdk.json)

@kaiz-io kaiz-io added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 2, 2024
@SGhotra1
Copy link
Contributor Author

SGhotra1 commented Nov 2, 2024

Please add DO_NOT_AUTOTEST to the root of your project. (same level as cdk.json)

Done :)

@SGhotra1 SGhotra1 requested a review from kaiz-io November 2, 2024 16:39
@kaiz-io kaiz-io enabled auto-merge (squash) November 2, 2024 18:14
@kaiz-io kaiz-io disabled auto-merge November 2, 2024 18:14
@kaiz-io
Copy link
Contributor

kaiz-io commented Nov 2, 2024

Thanks, can you update the branch with the latest from main and am not able to push it to your branch. I cannot merge otherwise.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 3, 2024
@kaiz-io kaiz-io merged commit 63d0cf7 into aws-samples:main Nov 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants