Skip to content
2 changes: 1 addition & 1 deletion ADFiOSReferenceApp/ADFBaseViewController.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/**
* A base controller for the view controllers within the app.
*
* Contains app specific defaults and convienience methods
* Contains app specific defaults and convenience methods
*/
@interface ADFBaseViewController : UIViewController
-(id)initWithTitle:(NSString*)title andImage:(UIImage*)image;
Expand Down
6 changes: 3 additions & 3 deletions ADFiOSReferenceApp/ADFBaseViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
/**
* A base controller for the view controllers within the app.
*
* Contains app specific defaults and convienience methods
* Contains app specific defaults and convenience methods
*/
@implementation ADFBaseViewController

Expand Down Expand Up @@ -81,7 +81,7 @@ -(void)centerViewByWidth:(UIView*)givenView{
}

/**
* Positions the view by centering vertially
* Positions the view by centering vertically
*
* @param givenView the view to position
*/
Expand Down Expand Up @@ -113,7 +113,7 @@ -(void)putView:(UIView*)bottom belowView:(UIView*)topView withPadding:(CGFloat)p
}

/**
* A convienience method so that the frame can be created with a point and size instead of CGRectMake
* A convenience method so that the frame can be created with a point and size instead of CGRectMake
*
* @param point the point of the frame
* @param frameSize the size of the frame
Expand Down
8 changes: 4 additions & 4 deletions ADFiOSReferenceApp/CustomWebSitePickerViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ @interface CustomWebSitePickerViewController ()
@end

static NSString* const FAULTY_URL_ERROR_MESSAGE_TITLE = @"Faulty URL Entered";
static NSString* const FAULTY_URL_ERROR_MESSAGE_MESSAGE = @"The url that you inputed: %@ is not in the right format. Please put in a url with the correct format. For example http://www.amazon.com";
static NSString* const FAULTY_URL_ERROR_MESSAGE_MESSAGE = @"The url that you input: %@ is not in the right format. Please put in a url with the correct format. For example http://www.amazon.com";
static NSString* const ALERT_CANCEL_BUTTON_TITLE = @"OK";
static NSString* const SUBMIT_BUTTON_TTITLE = @"Go";
static NSString* const SUBMIT_BUTTON_TITLE = @"Go";
static NSString* const TEXT_FIELD_PLACE_HOLDER_WEBSITE = @"http://www.amazon.com";
static NSString* const TEXT_FIELD_ACCESSIBILITY_LABEL = @"navigation bar";
static NSString* const NAVIGATION_TITLE = @"Input a website";
Expand Down Expand Up @@ -73,7 +73,7 @@ -(void)configureComponents{
_urlInputTextField.autocorrectionType = UITextAutocorrectionTypeNo;
[_urlInputTextField addTarget:self action:@selector(goButtonPressed:) forControlEvents:UIControlEventEditingDidEndOnExit];

[_goButton setTitle:SUBMIT_BUTTON_TTITLE forState:UIControlStateNormal];
[_goButton setTitle:SUBMIT_BUTTON_TITLE forState:UIControlStateNormal];
_goButton.titleLabel.textAlignment = NSTextAlignmentCenter;
_goButton.titleLabel.font = [UIFont largeFont];
_goButton.backgroundColor = [UIColor flatLightBlue];
Expand All @@ -92,7 +92,7 @@ -(void)displayComponents{
}

/**
* Goes to the enterned url
* Goes to the entered url
*
* @param sender the go button
*/
Expand Down
2 changes: 1 addition & 1 deletion ADFiOSReferenceApp/GesturesViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ -(IBAction)handlePanGesture:(UIPanGestureRecognizer*)recognizer {
/**
* Action for the pinch gesture. Scales the image based on touch.
*
* @param recognizer the gesture regonizer.
* @param recognizer the gesture recognizer.
*/
-(IBAction)handlePinchGesture:(UIPinchGestureRecognizer*)recognizer {
recognizer.view.transform = CGAffineTransformScale(recognizer.view.transform, recognizer.scale, recognizer.scale);
Expand Down
4 changes: 2 additions & 2 deletions ADFiOSReferenceApp/ScrollOutOfViewViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ @interface ScrollOutOfViewViewController ()
@property UILabel *label;
@end

static NSString* const HIDDENT_TEXT = @"This is hidden text";
static NSString* const HIDDEN_TEXT = @"This is hidden text";

/**
* Scroll out of view view controller
Expand All @@ -36,7 +36,7 @@ - (void)viewDidLoad {
*/
-(void)setUpView{
_label = [[UILabel alloc] initWithFrame:CGRectMake(0, self.view.frame.size.height * 2, 0, 0)];
_label.text = HIDDENT_TEXT;
_label.text = HIDDEN_TEXT;
[_label sizeToFit];

UIScrollView *scrollView = [[UIScrollView alloc] initWithFrame:self.view.frame];
Expand Down
2 changes: 1 addition & 1 deletion ADFiOSReferenceApp/SubmitButtonViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ -(void)submitButtonPressed:(UIButton*)sender{
}

/**
* Changes the button's color to origional when released
* Changes the button's color to original when released
*
* @param sender the button
*/
Expand Down
2 changes: 1 addition & 1 deletion ADFiOSReferenceApp/UIColor+ColorExtension.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#import <UIKit/UIKit.h>

/**
* A convience class that returns app specific colours
* A convenience class that returns app specific colours
*/
@interface UIColor (ColorExtension)
+ (UIColor*)flatOrange;
Expand Down
2 changes: 1 addition & 1 deletion ADFiOSReferenceApp/UIColor+ColorExtension.m
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#import "UIColor+ColorExtension.h"

/**
* A convience class that returns app specific colours
* A convenience class that returns app specific colours
*/
@implementation UIColor (ColorExtension)
+ (UIColor*)flatOrange {
Expand Down
2 changes: 1 addition & 1 deletion ADFiOSReferenceApp/WebViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ - (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error {
}

/**
* Sets the accessibility for the webview to loaded if the webview succeded (used for testing)
* Sets the accessibility for the webview to loaded if the webview succeeded (used for testing)
*
* @param webView the webview
*/
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This is a sample native iOS app that contains many of the stock iOS components a
You can use this app and example test suite as a reference for your own Device Farm tests.

##### **Notes**
All of the views are programatically created within the app. Storyboard or XIB files are not used. This is to prevent merge conflicts in the future.
All of the views are programmatically created within the app. Storyboard or XIB files are not used. This is to prevent merge conflicts in the future.

Explicit delays are occasionally added to the tests to allow the page to fully render, they are commented as such in the code.

Expand Down Expand Up @@ -111,4 +111,4 @@ XCTAssertNotNil(app.staticTexts["This is a modal view"])
12. To run the tests go to Product —> Test. This will open up the simulator and run the tests.
13. We want to package and upload these tests to Device Farm to test it against a number of devices. </br>
To package the tests go to your Project explorer on the left hand side. Right click on AWSDeviceFarmiOSReferenceApp under Products folder —> Show in Finder. This will take to the location of your app and tests build output. Look for the runner app of your tests: AWSDeviceFarmiOSReferenceAppUITests_Mock-Runner. Create a folder named “Payload” case-sensitive anywhere in your file system. Copy the tests runner app inside Payload. Right click on Payload —> Compress Payload. Rename the extensions of the compressed zip file to .ipa. When asked if you want to keep .ipa option choose yes. This is your test IPA that can be uploaded to AWS Device Farm.
14. You can build an IPA of the app using your developer account or a pre-built version of the app and tests can be found [here](https://s3.console.aws.amazon.com/s3/buckets/prebuiltappsreinvent2017/).
14. You can build an IPA of the app using your developer account or use [a pre-built version of the app and tests](https://s3.console.aws.amazon.com/s3/buckets/prebuiltappsreinvent2017/).
6 changes: 3 additions & 3 deletions calabash.framework/Headers/LPHTTPAsyncFileResponse.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* This is an asynchronous version of LPHTTPFileResponse.
* It reads data from the given file asynchronously via LPGCD.
*
* It may be overriden to allow custom post-processing of the data that has been read from the file.
* It may be overridden to allow custom post-processing of the data that has been read from the file.
* An example of this is the LPHTTPDynamicFileResponse class.
**/

Expand Down Expand Up @@ -51,7 +51,7 @@
*
* readOffset
* Represents the offset of the file descriptor.
* In other words, the file position indidcator for our read stream.
* In other words, the file position indicator for our read stream.
* It might be easy to think of it as the total number of bytes that have been read from the file.
* However, this isn't entirely accurate, as the setOffset: method may have caused us to
* jump ahead in the file (lseek).
Expand All @@ -71,5 +71,5 @@
* It's NOT OK if we return a greater number of bytes to the connection.
* Doing so would disrupt proper support for range requests.
* If, however, the response is chunked then we don't need to worry about this.
* Chunked responses inheritly don't support range requests.
* Chunked responses inherently don't support range requests.
**/
4 changes: 2 additions & 2 deletions calabash.framework/Headers/LPHTTPResponse.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
*
* Important: You should read the discussion at the bottom of this header.
**/
- (BOOL)delayResponeHeaders;
- (BOOL)delayResponseHeaders;

/**
* Status code for response.
Expand Down Expand Up @@ -96,7 +96,7 @@
* each chunk. Please see the LPHTTPAsyncFileResponse class for an example of how to do this.
*
* The normal flow of events for an LPHTTPConnection while responding to a request is like this:
* - Send http resopnse headers
* - Send http response headers
* - Get data from response via readDataOfLength method.
* - Add data to asyncSocket's write queue.
* - Wait for asyncSocket to notify it that the data has been sent.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* This is an asynchronous version of LPHTTPFileResponse.
* It reads data from the given file asynchronously via LPGCD.
*
* It may be overriden to allow custom post-processing of the data that has been read from the file.
* It may be overridden to allow custom post-processing of the data that has been read from the file.
* An example of this is the LPHTTPDynamicFileResponse class.
**/

Expand Down Expand Up @@ -51,7 +51,7 @@
*
* readOffset
* Represents the offset of the file descriptor.
* In other words, the file position indidcator for our read stream.
* In other words, the file position indicator for our read stream.
* It might be easy to think of it as the total number of bytes that have been read from the file.
* However, this isn't entirely accurate, as the setOffset: method may have caused us to
* jump ahead in the file (lseek).
Expand All @@ -71,5 +71,5 @@
* It's NOT OK if we return a greater number of bytes to the connection.
* Doing so would disrupt proper support for range requests.
* If, however, the response is chunked then we don't need to worry about this.
* Chunked responses inheritly don't support range requests.
* Chunked responses inherently don't support range requests.
**/
4 changes: 2 additions & 2 deletions calabash.framework/Versions/0.13.0/Headers/LPHTTPResponse.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
*
* Important: You should read the discussion at the bottom of this header.
**/
- (BOOL)delayResponeHeaders;
- (BOOL)delayResponseHeaders;

/**
* Status code for response.
Expand Down Expand Up @@ -96,7 +96,7 @@
* each chunk. Please see the LPHTTPAsyncFileResponse class for an example of how to do this.
*
* The normal flow of events for an LPHTTPConnection while responding to a request is like this:
* - Send http resopnse headers
* - Send http response headers
* - Get data from response via readDataOfLength method.
* - Add data to asyncSocket's write queue.
* - Wait for asyncSocket to notify it that the data has been sent.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* This is an asynchronous version of LPHTTPFileResponse.
* It reads data from the given file asynchronously via LPGCD.
*
* It may be overriden to allow custom post-processing of the data that has been read from the file.
* It may be overridden to allow custom post-processing of the data that has been read from the file.
* An example of this is the LPHTTPDynamicFileResponse class.
**/

Expand Down Expand Up @@ -51,7 +51,7 @@
*
* readOffset
* Represents the offset of the file descriptor.
* In other words, the file position indidcator for our read stream.
* In other words, the file position indicator for our read stream.
* It might be easy to think of it as the total number of bytes that have been read from the file.
* However, this isn't entirely accurate, as the setOffset: method may have caused us to
* jump ahead in the file (lseek).
Expand All @@ -71,5 +71,5 @@
* It's NOT OK if we return a greater number of bytes to the connection.
* Doing so would disrupt proper support for range requests.
* If, however, the response is chunked then we don't need to worry about this.
* Chunked responses inheritly don't support range requests.
* Chunked responses inherently don't support range requests.
**/
4 changes: 2 additions & 2 deletions calabash.framework/Versions/A/Headers/LPHTTPResponse.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
*
* Important: You should read the discussion at the bottom of this header.
**/
- (BOOL)delayResponeHeaders;
- (BOOL)delayResponseHeaders;

/**
* Status code for response.
Expand Down Expand Up @@ -96,7 +96,7 @@
* each chunk. Please see the LPHTTPAsyncFileResponse class for an example of how to do this.
*
* The normal flow of events for an LPHTTPConnection while responding to a request is like this:
* - Send http resopnse headers
* - Send http response headers
* - Get data from response via readDataOfLength method.
* - Add data to asyncSocket's write queue.
* - Wait for asyncSocket to notify it that the data has been sent.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* This is an asynchronous version of LPHTTPFileResponse.
* It reads data from the given file asynchronously via LPGCD.
*
* It may be overriden to allow custom post-processing of the data that has been read from the file.
* It may be overridden to allow custom post-processing of the data that has been read from the file.
* An example of this is the LPHTTPDynamicFileResponse class.
**/

Expand Down Expand Up @@ -51,7 +51,7 @@
*
* readOffset
* Represents the offset of the file descriptor.
* In other words, the file position indidcator for our read stream.
* In other words, the file position indicator for our read stream.
* It might be easy to think of it as the total number of bytes that have been read from the file.
* However, this isn't entirely accurate, as the setOffset: method may have caused us to
* jump ahead in the file (lseek).
Expand All @@ -71,5 +71,5 @@
* It's NOT OK if we return a greater number of bytes to the connection.
* Doing so would disrupt proper support for range requests.
* If, however, the response is chunked then we don't need to worry about this.
* Chunked responses inheritly don't support range requests.
* Chunked responses inherently don't support range requests.
**/
4 changes: 2 additions & 2 deletions calabash.framework/Versions/Current/Headers/LPHTTPResponse.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
*
* Important: You should read the discussion at the bottom of this header.
**/
- (BOOL)delayResponeHeaders;
- (BOOL)delayResponseHeaders;

/**
* Status code for response.
Expand Down Expand Up @@ -96,7 +96,7 @@
* each chunk. Please see the LPHTTPAsyncFileResponse class for an example of how to do this.
*
* The normal flow of events for an LPHTTPConnection while responding to a request is like this:
* - Send http resopnse headers
* - Send http response headers
* - Get data from response via readDataOfLength method.
* - Add data to asyncSocket's write queue.
* - Wait for asyncSocket to notify it that the data has been sent.
Expand Down
2 changes: 1 addition & 1 deletion features/ios/pages/nested_view_page.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def press_back_button_times(number_times)
touch ("UILabel text:'Back'")
end

# Presses the next level back button a a specific amount of times
# Presses the next level back button a specific amount of times
def press_next_level_button(number_times)
puts("Custom")
number_times.to_i.times do
Expand Down