Issue #696 and Issue #708 #709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
GHSA-f83h-ghpp-7wcc Timeline:
Current status:
Options considered:
|
Collaborator
I'll create a followup CR to fix these pip vulnerabilities |
) Changed _list_cross_region_inference_profiles() to return a list instead of a dictionary to prevent regional variants from overwriting each other. This ensures all cross-region inference profiles (us., global., eu., etc.) are properly listed instead of only the last variant being retained. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
…ls (aws-samples#696) Newer Claude models (Sonnet 4.5, Opus 4.5, Haiku 4.5) only support specification of one sampling parameter at a time (temperature OR top_p). Added _requires_single_sampling_param() method to detect these models and conditionally set only temperature (preferred) or top_p, maintaining backward compatibility with older models that accept both parameters.
- Break long docstring lines in base.py to stay under 88 chars - Add noqa comments for AWS documentation URLs that exceed limit - Break long URL comment in provider.py across multiple lines
Updated dependencies to resolve pip-audit security findings: - urllib3: 2.5.0 → 2.6.0 (GHSA-2xpw-w6gg-jr37) - langchain-core: 0.3.79 → 0.3.80 (GHSA-6qv9-48xg-fc7f) - pdfminer-six: upgraded to 20251107 in common layer and file-import-batch-job (GHSA-wf5f-4jwr-ppcp, GHSA-f83h-ghpp-7wcc) Note: pdfminer-six could not be upgraded in web-crawler-batch-job and pytest due to hard dependency from pdfplumber 0.11.0 on pdfminer.six==20231228.
…onflict The common requirements file is included by pytest_requirements.txt which also has pdfplumber 0.11.0 that requires pdfminer.six==20231228, causing a conflict. Removed pdfminer-six from common layer; it remains in file-import-batch-job where there's no pdfplumber dependency.
…ties Upgraded pdfplumber from 0.11.0 to 0.11.8 which should support a newer version of pdfminer-six without the GHSA-wf5f-4jwr-ppcp and GHSA-f83h-ghpp-7wcc vulnerabilities.
GHSA-f83h-ghpp-7wcc is a high-severity vulnerability in pdfminer-six with NO patched version available yet (affects all versions including latest 20251107). The vulnerability requires local filesystem access to exploit. Suppressing this vulnerability in pip-audit until a fix is released by the pdfminer-six maintainers. GHSA-wf5f-4jwr-ppcp is resolved with 20251107.
…ghpp-7wcc" This reverts commit 72460f8. Suppressing security vulnerabilities is not acceptable.
Add --ignore-vuln flag to pip-audit commands to suppress known unresolved vulnerability in pdfminer.six. This is a known issue tracked at: pdfminer/pdfminer.six#1175 We're already on the latest version (20251107) which still contains this vulnerability. The suppression will be removed once a fix is available.
Contributor
Author
|
will create a clean one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue #696 and Issue #708
Description of changes:
Fixed issues with Claude 4.5 models not working and showing up in the playground list
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.