Skip to content

Add 'data' param to EIP-1559 to allow contract calls#9

Open
albydarned wants to merge 3 commits intoaws-samples:mainfrom
albydarned:data-parameter
Open

Add 'data' param to EIP-1559 to allow contract calls#9
albydarned wants to merge 3 commits intoaws-samples:mainfrom
albydarned:data-parameter

Conversation

@albydarned
Copy link

Issue #, if available:

Description of changes:
This is a very simple change that adds a 'data' param to the EIP-1559 lambda function so contract calls can be made. Thank you very much for this example, it was extremely helpful.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ikmzkro
Copy link

ikmzkro commented Mar 15, 2025

@albydarned
Thanks for the update!

Just wondering — while adding support for the data field increases flexibility, do you think this approach is general-purpose enough for broader use cases?

In practice, many developers may find it difficult to manually prepare ABI-encoded calldata when invoking the Lambda function. Unless the caller has tooling to encode data correctly, this might be hard to use effectively.

Would it make sense to consider a higher-level abstraction (e.g., providing method and args instead of raw data) to improve usability?

Curious to hear your thoughts — thanks again!

@albydarned
Copy link
Author

Hey there! Yes, I think that makes sense. Especially if the goal of this is to abstract some of the more complicated stuff away. I can try to make this abstraction, but right now I don't need it so it might not happen soon.

I think I have made a few other modifications along these lines, I will make another PR if I find them to be useful to everyone. Mostly just more parameters, like the ability to change the chain id etc. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants