Skip to content

AddCustomActionSHResource1 DELETE_FAILED at stack deletion of 'SecurityHub_to_AWSChatBot.yml' #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o2346 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

AddCustomActionSHResource1 DELETE_FAILED at stack deletion of 'SecurityHub_to_AWSChatBot.yml' #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e49e20
behave appropreately on deletion
Jul 2, 2020
bab4eaa
handle exception & proper cfnresponce
Jul 4, 2020
6c27a1a
spelling
Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions SecurityHub_to_AWSChatBot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ Resources:
- Effect: Allow
Action:
- 'securityhub:CreateActionTarget'
- 'securityhub:DeleteActionTarget'
Resource: '*'
Roles:
- !Ref LambdaIAMRole
Expand All @@ -85,13 +86,37 @@ Resources:
Code:
ZipFile: |
import boto3
import os
import cfnresponse
def lambda_handler(event, context):
securityhub = boto3.client('securityhub')
response = securityhub.create_action_target(Name="Send_To_Slack",Description='Send Messages to ChatApplication via AWS ChatBot',Id='SendToSlack')
responseData = {}
responseData['Data'] = response
cfnresponse.send(event, context, cfnresponse.SUCCESS, responseData, "CustomResourcePhysicalID")
responseStatus = cfnresponse.SUCCESS
if event['RequestType'] == 'Create':
try:
responseData['Data'] = securityhub.create_action_target(Name="Send_To_Slack",Description='Send Messages to ChatApplication via AWS ChatBot',Id='SendToSlack')
except Exception as e:
responseData['Data'] = str(e)
responseStatus = cfnresponse.FAILED

if event['RequestType'] == 'Delete':
try:
arnDeleteTo = ''.join( [
'arn:aws:securityhub:',
os.environ.get('AWS_REGION'),
':',
boto3.client('sts').get_caller_identity().get('Account'),
':action/custom/SendToSlack'
] )
responseData['Data'] = securityhub.delete_action_target(ActionTargetArn=arnDeleteTo)
except securityhub.exceptions.ResourceNotFoundException as rnfe:
responseData['Data'] = str(rnfe)
except Exception as e:
responseData['Data'] = str(e)
responseStatus = cfnresponse.FAILED

cfnresponse.send(event, context, responseStatus, responseData, "CustomResourcePhysicalID")

MemorySize: 128
Timeout: 10
Role: !GetAtt LambdaIAMRole.Arn
Expand Down