Skip to content

correct time formating + cleaner findings description #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentinroca wants to merge 2 commits into
base: master
Choose a base branch
from
Open

correct time formating + cleaner findings description #9

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
792f210
correct time formating + cleaner findings description
valentinroca Apr 20, 2020
6eb7ed3
Merge branch 'aws-samples:master' into master
valentinroca Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SecurityHubFindingsToSlack.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"Name" : "SecurityHubFindingsToSlack",
"Description": "CloudWatchEvents Rule to enable SecurityHub Findings in Slack ",
"State": "ENABLED",
"EventPattern" : {
"EventPattern" : {
"source": ["aws.securityhub"],
"resources": [{ "Fn::Join" : [ ":", [ "arn", "aws", "securityhub", { "Ref" : "AWS::Region" }, { "Ref" : "AWS::AccountId" }, { "Fn::Join" : [ "/", [ "action", "custom", "SendToSlack"] ] }]
]}]},
Expand Down Expand Up @@ -141,7 +141,7 @@
"const consoleUrl = `https://console.aws.amazon.com/securityhub`;\n",
"const finding = message.detail.findings[0].Types[0];\n",
"const findingDescription = message.detail.findings[0].Description;\n",
"const findingTime = message.detail.findings[0].updatedAt;\n",
"const findingTime = message.detail.findings[0].UpdatedAt;\n",
"const findingTimeEpoch = Math.floor(new Date(findingTime) / 1000);\n",
"const account = message.detail.findings[0].AwsAccountId;\n",
"const region = message.detail.findings[0].Resources[0].Region;\n",
Expand All @@ -159,7 +159,7 @@
"\n",
"const attachment = [{\n",
"\"fallback\": finding + ` - ${consoleUrl}/home?region=` + `${region}#/findings?search=id%3D${messageId}`,\n",
"\"pretext\": `*AWS SecurityHub finding in ${region} for Acct: ${account}*`,\n",
"\"pretext\": `*AWS Security Hub finding for account: ${account}*`,\n",
"\"title\": `${finding}`,\n",
"\"title_link\": `${consoleUrl}/home?region=${region}#/research`,\n",
"\n",
Expand Down