-
Notifications
You must be signed in to change notification settings - Fork 159
mtc with rlvr #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
mtc with rlvr #912
Conversation
KeitaW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
3.test_cases/pytorch/verl/rlvr/managed-tiered-checkpointing/mtc-grpo-cluster.yaml
Show resolved
Hide resolved
|
|
||
| Clone MTC-enabled VERL code. This is a fork from the main VERL repo that has modified checkpointing code to enabled managed tiered checkpointing: | ||
| ``` | ||
| git clone https://github.com/aruncs2005/verl.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to guide how to modify the training code base to make it compatible with managed tier checkpointing, instead of using the folk. The folk is already 389 commits behind.
3.test_cases/pytorch/verl/rlvr/managed-tiered-checkpointing/submit-mtc-grpo.sh
Show resolved
Hide resolved
| If you get an error about OIDC provider, install eksctl: | ||
| ```bash | ||
| # macOS | ||
| brew install eksctl | ||
|
|
||
| # Linux | ||
| curl --silent --location "https://github.com/weaveworks/eksctl/releases/latest/download/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp | ||
| sudo mv /tmp/eksctl /usr/local/bin | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need eksctl?
| echo "✓ OIDC provider already exists" | ||
| else | ||
| echo "Creating OIDC provider..." | ||
| eksctl utils associate-iam-oidc-provider --cluster=${EKS_CLUSTER_NAME} --region=${AWS_REGION} --approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need eksctl even when we set up a cluster without eksctl?
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.