Skip to content

Return tool_calls when finish_reason is "max_tokens". #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return tool_calls when finish_reason is "max_tokens". #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions src/api/models/bedrock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,29 @@ def _estimate_reasoning_tokens(self, content: list[dict]) -> int:
return len(ENCODER.encode(reasoning_text))
return 0

def _append_tool_use(
self,
message: ChatResponseMessage,
tool: dict,
):
# https://docs.aws.amazon.com/bedrock/latest/userguide/tool-use.html#tool-use-examples
tool_calls = []
tool_calls.append(
ToolCall(
id=tool["toolUseId"],
type="function",
function=ResponseFunction(
name=tool["name"],
arguments=json.dumps(tool["input"]),
),
)
)
if message.tool_calls is None:
message.tool_calls = tool_calls
else:
message.tool_calls += tool_calls
message.content = None

def _create_response(
self,
model: str,
Expand All @@ -874,23 +897,10 @@ def _create_response(
role="assistant",
)
if finish_reason == "tool_use":
# https://docs.aws.amazon.com/bedrock/latest/userguide/tool-use.html#tool-use-examples
tool_calls = []
for part in content:
if "toolUse" in part:
tool = part["toolUse"]
tool_calls.append(
ToolCall(
id=tool["toolUseId"],
type="function",
function=ResponseFunction(
name=tool["name"],
arguments=json.dumps(tool["input"]),
),
)
)
message.tool_calls = tool_calls
message.content = None
self._append_tool_use(message, tool)
else:
message.content = ""
for c in content:
Expand All @@ -900,9 +910,12 @@ def _create_response(
].get("text", "")
elif "text" in c:
message.content = c["text"]
elif "toolUse" in c:
tool = c["toolUse"]
self._append_tool_use(message, tool)
else:
logger.warning(
"Unknown tag in message content " + ",".join(c.keys())
"Unknown tag in message content " + ",".join(c.keys()) + ". finish_reason is: " + finish_reason
)
if message.reasoning_content:
message.content = f"<think>{message.reasoning_content}</think>{message.content}"
Expand Down