add union pattern #192
add union pattern #192
Conversation
shapirov103
left a comment
shapirov103
left a comment
There was a problem hiding this comment.
Please see my a few comments.
|
|
||
| const unionConfig: union.UnionDataplaneAddOnProps = { | ||
| orgName: getJsonSecret(unionSecretString, "orgName"), | ||
| clientIdSecretName: "union-client-id", |
There was a problem hiding this comment.
multiple secrets here: are they by design or was there a technical limitation you were trying to work around (since I see getJsonSecret function)?
Why have separate union client and and union client secret name in separate secrets? these appear to always go together.
There was a problem hiding this comment.
That's how I set it up in the actual addon, will make changes there and update
There was a problem hiding this comment.
Will likely just add the same getJsonSecret fn in the addon there
| .account(process.env.CDK_DEFAULT_ACCOUNT!) | ||
| .region(process.env.CDK_DEFAULT_REGION) | ||
| .addOns(new KubesharkAddOn()) | ||
| .addOns(new KubesharkAddOn({repository: "https://helm.kubeshark.com"})) |
There was a problem hiding this comment.
was it failing on helm validation?
There was a problem hiding this comment.
Yes, they moved the charts from .co to .com
| @@ -0,0 +1,140 @@ | |||
| # Union.ai on EKS Pattern | |||
|
|
|||
| Union.ai empowers AI development teams to rapidly ship high-quality code to production by offering optimized performance, unparalleled resource efficiency, and a delightful workflow authoring experience. With Union.ai your team can: | |||
There was a problem hiding this comment.
Once we host it, it becomes an AWS resource. Let's drop "unparalleled".
| Union.ai empowers AI development teams to rapidly ship high-quality code to production by offering optimized performance, unparalleled resource efficiency, and a delightful workflow authoring experience. With Union.ai your team can: | ||
|
|
||
| - Run complex AI workloads with performance, scale, and efficiency. | ||
| - Achieve millisecond-level execution times with reusable containers. |
There was a problem hiding this comment.
was it validated? are we actually observing ms level execution times?
| On Mac: | ||
| ```bash | ||
| brew tap unionai/homebrew-tap | ||
| brew install uctl |
There was a problem hiding this comment.
why do i need uctl to run the pattern?
There was a problem hiding this comment.
You currently need uctl to provision dataplane credentials
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.