move lambda creation to external template

Author: mwunderl

.ebextensions/lambda-function.config

@@ -4,6 +4,9 @@ commands:
     cwd: /home/ec2-user
     test: "[ ! -d /home/ec2-user/.nvm ]"
 
+packages:
+  python:
+    awscli: 1.11.79
 container_commands:
   update-random-name:
     command: /tmp/update-lambda.sh
@@ -32,9 +35,9 @@ files:
       #!/bin/bash
       REGION=$(/opt/elasticbeanstalk/bin/get-config environment -k AWS_REGION)
       STAGINGDIR=$(/opt/elasticbeanstalk/bin/get-config container -k container_staging_dir)
-      TOPIC=$(/opt/elasticbeanstalk/bin/get-config environment -k NOTIFICATION_TOPIC))
+      TOPIC=$(/opt/elasticbeanstalk/bin/get-config environment -k NOTIFICATION_TOPIC)
       cd _lambda/random-name
       /home/ec2-user/bin/npm install
       zip -r ../random-name.zip *
       aws lambda update-function-code --function-name random-name --zip-file fileb://../random-name.zip --region $REGION
-      aws lambda update-function-configuration --function-name random-name --environment "{\"Variables\": {\"NOTIFICATION_TOPIC\": \"$TOPIC\"} }"
+      aws lambda update-function-configuration --function-name random-name --environment "{\"Variables\": {\"TOPIC_ARN\": \"$TOPIC\"} }" --region $REGION

_lambda/lambda-role.yml

@@ -19,7 +19,6 @@ Resources:
         - arn:aws:iam::aws:policy/AmazonSNSFullAccess
         - arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
       Path: /service-role/
-      RoleName: scorekeep-lambda
 
   RandomNameFunction:
     Type: "AWS::Lambda::Function"
@@ -29,9 +28,8 @@ Resources:
       Description: "Generate random names"
       Environment:
         Variables:
-          REGION_NAME: {"Ref" : "AWS::Region"}
           TOPIC_ARN: "PLACEHOLDER"
       FunctionName: random-name
       Handler: index.handler
-      Role: { "Fn::Join": [ "", [ "arn:aws:iam::",{"Ref" : "AWS::AccountId"},":role/service-role/scorekeep-lambda" ] ] }
+      Role: { "Fn::GetAtt": ["RandomNameRole", "Arn"] }
       Runtime: nodejs4.3