feat: implement permission validation for Slack slash commands #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add permission_models.py with PermissionConfig and PermissionMode - Implement validate_user_permissions() with three modes: * allow-all (default, backward compatible) * watcher-based (validates against case watchers) * user-mapping (explicit Slack-to-AWS identity mapping) - Add admin user override and read-only command support - Update CDK stack to include permission config SSM parameter - Add comprehensive unit tests (14 tests, all passing) - Implement fail-closed security (denies on errors) - Add detailed logging for all permission checks Resolves TODO in assets/slack_command_handler/index.py line 193
Resolved conflicts in assets/slack_command_handler/index.py by: - Keeping enhanced permission validation with command parameter - Adding upstream's detailed logging for permission denials - Preserving all upstream improvements (incident-details command, mark_slack_update, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves TODO in assets/slack_command_handler/index.py line 193
Description
Brief description of the changes made.Type of change (Choose 1)
Reason for this change
Brief description of why these changes need to be made.Related Issue (if applicable)
Link to any related issuesContributor Task List
New Integration Target Questions
If you are introducing a new integration target, additional scrutiny is applied to ensure a high bar is maintained.
For details on this review visit Pull Request Review Rubric.
How does the components of this integration communicate with each
Provide a brief description or attach an architecture diagram to this PR.How does the integration authenticated and authorize connections between the integration and the target
Provide a brief description or attach a sequence diagram to this PR.What kind of compute is used by this integration
Other: Provide a brief description or attach an architecture diagram to this PR.How is state / caching maintained in the integration
Provide a brief description or attach a sequence diagram to this PR.How much do you expect this integration to cost
Provide a brief set estimate or attach an estimate from https://calculator.aws/By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution license