Commit 0701 #17
Open
Commit 0701 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds AWS ECR (Elastic Container Registry) support to the docker-reverse-proxy, allowing it to work with both GCP Artifact Registry and AWS ECR. Key changes include: - Add cloud provider detection based on CLOUD_PROVIDER environment variable - Implement AWS ECR authentication using AWS SDK - Add support for dynamic AWS account ID discovery via STS - Make AWS credentials optional to support EC2 instance roles - Centralize AWS configuration in shared/pkg/consts/aws.go - Add proper path handling for AWS ECR repositories - Update proxy logic to handle both GCP and AWS specific paths With this change, users can configure the docker-reverse-proxy to work with AWS ECR by setting CLOUD_PROVIDER=aws and providing the required AWS configuration (AWS_ECR_REPOSITORY_NAME is req uired, while AWS_REGION, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_ACCOUNT_ID are optional when running on EC2 with instance roles).
- Relocated AWS constants from shared/pkg/consts to docker-reverse-proxy/internal/constants - Updated proxy path mapping for better repository name handling - Added detailed debug logging in proxy handler for better troubleshooting - Improved token handling and authentication flow tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.