Fixing remaining eslint errors

Author: morishwe

src/ui/.eslintrc.json

@@ -17,7 +17,7 @@
   "rules": {
     "no-console": "off",
     "no-alert": "off",
-    "max-len": ["error", { "code": 120, "ignoreUrls": true, "ignoreTemplateLiterals": true }],
+    "max-len": ["error", { "code": 120, "ignoreUrls": true, "ignoreTemplateLiterals": true, "ignoreComments": true }],
     "linebreak-style": ["error", "unix"],
     "react/jsx-filename-extension": [
       "warn",

src/ui/src/components/common/ReprocessDocumentModal.jsx

@@ -63,6 +63,4 @@ ReprocessDocumentModal.propTypes = {
   ),
 };
 
-
-
 export default ReprocessDocumentModal;

src/ui/src/components/configuration-layout/ConfigurationLayout.jsx

@@ -286,12 +286,16 @@ const ConfigurationLayout = () => {
                             // Only check constraints if it's a valid number
                             if (isValidNumber && itemProp.minimum !== undefined && numValue < itemProp.minimum) {
                               errors.push({
-                                message: `Field '${itemKey}' in item ${index} of '${key}' must be at least ${itemProp.minimum}`,
+                                message:
+                                  `Field '${itemKey}' in item ${index} of '${key}' must be ` +
+                                  `at least ${itemProp.minimum}`,
                               });
                             }
                             if (isValidNumber && itemProp.maximum !== undefined && numValue > itemProp.maximum) {
                               errors.push({
-                                message: `Field '${itemKey}' in item ${index} of '${key}' must be at most ${itemProp.maximum}`,
+                                message:
+                                  `Field '${itemKey}' in item ${index} of '${key}' must be ` +
+                                  `at most ${itemProp.maximum}`,
                               });
                             }
                           }
@@ -504,7 +508,8 @@ const ConfigurationLayout = () => {
       const compareWithDefault = (current, defaultObj, path = '') => {
         // Add debugging for granular assessment
         if (path.includes('granular')) {
-          console.log(`DEBUG: compareWithDefault called with path '${path}':`, {  // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
+          console.log(`DEBUG: compareWithDefault called with path '${path}':`, {
+            // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
             current,
             currentType: typeof current,
             defaultObj,
@@ -593,7 +598,8 @@ const ConfigurationLayout = () => {
 
             // Add debugging for granular assessment
             if (newPath.includes('granular')) {
-              console.log(`DEBUG: Comparing object key '${key}' at path '${newPath}':`, {  // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
+              console.log(`DEBUG: Comparing object key '${key}' at path '${newPath}':`, {
+                // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
                 currentValue: current[key],
                 defaultValue: defaultObj[key],
                 keyInCurrent: key in current,
@@ -611,7 +617,8 @@ const ConfigurationLayout = () => {
 
               // Add debugging for granular assessment
               if (newPath.includes('granular')) {
-                console.log(`DEBUG: Recursive call result for '${newPath}':`, {  // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
+                console.log(`DEBUG: Recursive call result for '${newPath}':`, {
+                  // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
                   nestedResults,
                   nestedResultsKeys: Object.keys(nestedResults),
                   nestedResultsLength: Object.keys(nestedResults).length,
@@ -627,7 +634,8 @@ const ConfigurationLayout = () => {
 
         // Handle primitive values
         if (current !== defaultObj) {
-          console.log(`DEBUG: Primitive difference detected at path '${path}':`, {  // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
+          console.log(`DEBUG: Primitive difference detected at path '${path}':`, {
+            // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Debug logging with controlled internal data
             current,
             currentType: typeof current,
             defaultObj,
@@ -699,7 +707,7 @@ const ConfigurationLayout = () => {
                 for (let i = 0; i < parts.length - 1; i += 1) {
                   // Use += 1 instead of ++
                   current[parts[i]] = {};
-                  current = current[parts[i]];  // nosemgrep: javascript.lang.security.audit.prototype-pollution.prototype-pollution-loop.prototype-pollution-loop - Index from controlled array iteration
+                  current = current[parts[i]]; // nosemgrep: javascript.lang.security.audit.prototype-pollution.prototype-pollution-loop.prototype-pollution-loop - Index from controlled array iteration
                 }
 
                 // Set the value at the final path - IMPORTANT: preserve boolean false values!

src/ui/src/components/configuration-layout/FormView.jsx

@@ -590,7 +590,7 @@ const FormView = ({
   // Define renderField first as a function declaration
   function renderField(key, property, path = '') {
     const currentPath = path ? `${path}.${key}` : key;
-    let value = getValueAtPath(formValues, currentPath);
+    const value = getValueAtPath(formValues, currentPath);
 
     // Add debugging for granular assessment
     if (currentPath.includes('granular')) {

src/ui/src/components/genaiidp-layout/GenAIIDPLayout.jsx

@@ -1,6 +1,7 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 import React, { useState } from 'react';
+import PropTypes from 'prop-types';
 import { Routes, Route } from 'react-router-dom';
 import { AppLayout, Flashbar } from '@cloudscape-design/components';
 
@@ -129,4 +130,8 @@ const GenAIIDPLayout = ({ children }) => {
   );
 };
 
+GenAIIDPLayout.propTypes = {
+  children: PropTypes.node,
+};
+
 export default GenAIIDPLayout;

src/ui/src/components/step-function-flow/StepDetails.jsx

@@ -46,6 +46,10 @@ const JsonDisplay = ({ data = null }) => {
   );
 };
 
+JsonDisplay.propTypes = {
+  data: PropTypes.oneOfType([PropTypes.string, PropTypes.object]),
+};
+
 // Helper function to check if a step is disabled based on configuration
 const isStepDisabled = (stepName, config) => {
   if (!config) return false;

src/ui/src/index.jsx

@@ -21,5 +21,5 @@ const root = createRoot(document.getElementById('root'));
 root.render(
   <React.StrictMode>
     <App />
-  </React.StrictMode>
+  </React.StrictMode>,
 );