Closed
Conversation
iakov-gan
reviewed
Jun 3, 2025
iakov-gan
reviewed
Jun 3, 2025
| s3_client = boto3.client('s3') | ||
|
|
||
| # RPO-RTO resilience report temp file headers | ||
| with open('/tmp/resilience-report.csv', 'w', newline='') as file: |
Contributor
There was a problem hiding this comment.
if there is any choice i would recommend using json for future compatibility
Contributor
Author
There was a problem hiding this comment.
csv is helping to display the dashbaords ; in phase 2 we can plan json
Contributor
iakov-gan
reviewed
Jun 13, 2025
iakov-gan
reviewed
Jun 13, 2025
| - !Join [ '', !Split [ ' ', !Ref RegionsInScope ] ] # remove spaces | ||
| LambdaAnalyticsARN: !GetAtt LambdaAnalytics.Arn | ||
| AccountCollectorLambdaARN: !Sub "${AccountCollector.Outputs.LambdaFunctionARN}" | ||
| CodeBucket: !If [ ProdCFNTemplateUsed, !FindInMap [RegionMap, !Ref "AWS::Region", CodeBucket], !Ref CFNSourceBucket ] |
Contributor
There was a problem hiding this comment.
do not think you need CodeBucket
iakov-gan
reviewed
Jun 13, 2025
| Type: AWS::S3::Bucket | ||
| DeletionPolicy: Delete | ||
| Properties: | ||
| BucketName: !Sub ${Name}.${AWS::Region} |
Contributor
There was a problem hiding this comment.
this will be in conflict with compute optimizer module
Contributor
Author
…ance and Increasing timeout to 15 mins in lambda (#364)
* Data Collection logging phase 1 * codify new SF version name * tweak account collector logging * Sync account collector with fix for manual account list * Add backoff/retry to standalone state machine * add more retry buffer * Misc cleanup * Temporarily re-indent the over indent to make the diff easier to read * Switch to pre-defined table * Fix merge issue * Merge main, normalize linked sf code file names * Interim commit * Checkpoint * beta * Pre-main merge instrumentation * Post merge main and cleanup * Fix misplaced space insertion * Refine Health detail execution logging * Add policy condition for CW logging * Update data-collection/deploy/deploy-data-collection.yaml * Tweak to output error message * Scale back Lambda-based monitoring * Renenable testing deploy of CaseSummary * Misc cleanup for easier merge * Misc cleanup for easier merge, 2 * Health SF correction from reversion of code * Health mod cleanup * Merge for push * post-merge * fix parameter * Update data-collection/deploy/module-health-events.yaml --------- Co-authored-by: Iakov Gan <iakov@amazon.com> Co-authored-by: Iakov GAN <82834333+iakov-aws@users.noreply.github.com>
* Update deploy-data-collection.yaml * refactor * refactor
Co-authored-by: Iakov Gan <iakov@amazon.com>
iakov-gan
reviewed
Jun 17, 2025
| DeletionPolicy: Delete | ||
| Properties: | ||
| BucketName: !Sub ${Name}.${AWS::Region} | ||
| BucketName: !Sub cid-data-${AWS::AccountId}.rh.${AWS::Region} |
iakov-gan
reviewed
Jun 19, 2025
| Type: String | ||
| Description: Name of the S3 Bucket to be created to hold data information. | ||
| AllowedPattern: (?=^.{3,63}$)(?!^(\d+\.)+\d+$)(^(([a-z0-9]|[a-z0-9][a-z0-9\-]*[a-z0-9])\.)*([a-z0-9]|[a-z0-9][a-z0-9\-]*[a-z0-9])$) | ||
| ManagementRoleName: |
Contributor
There was a problem hiding this comment.
Do we need it on Payer account level or on Linked account level?
Contributor
Author
There was a problem hiding this comment.
Linked Account level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.