Skip to content

Added condition UseExistingGlueDatabase #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added condition UseExistingGlueDatabase #376

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d41172
Added condition UseExistingGlueDatabase
Bauxitiego Aug 20, 2024
4ea2918
replaced !if with Condition UseExistingGlueDatabase
Bauxitiego Aug 20, 2024
ce91bf3
changes name from legislators of the default db name
Bauxitiego Aug 20, 2024
23fe26f
updated condition statement
Bauxitiego Aug 20, 2024
28405f0
fix: cfn-lint to fix issues
Bauxitiego Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sdlf-dataset/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Parameters:
Description: The name of the dataset (all lowercase, no symbols or spaces)
Type: String
AllowedPattern: "[a-z0-9]{2,14}"
Default: "default"
pEnvironment:
Description: Environment name
Type: String
Expand Down Expand Up @@ -45,10 +46,14 @@ Parameters:
}
}
}

Conditions:
UseExistingGlueDatabase: !Not [!Equals [!Ref pDatasetName, default]]

Resources:
######## GLUE #########
rGlueDataCatalog:
Condition: UseExistingGlueDatabase
Type: AWS::Glue::Database
Properties:
CatalogId: !Ref AWS::AccountId
Expand All @@ -57,8 +62,9 @@ Resources:
Name: !Sub ${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_${pDatasetName}_db

rGlueDataCatalogLakeFormationTag:
Type: AWS::LakeFormation::TagAssociation
Properties:
Condition: UseExistingGlueDatabase
Type: AWS::LakeFormation::TagAssociation
Properties:
Resource:
Database:
CatalogId: !Ref AWS::AccountId
Expand All @@ -70,6 +76,7 @@ Resources:
- !Sub ${pTeamName}

rGlueCrawler:
Condition: UseExistingGlueDatabase
Type: AWS::Glue::Crawler
Properties:
Role: !Sub "{{resolve:ssm:/SDLF/IAM/${pTeamName}/CrawlerRoleArn}}"
Expand All @@ -81,6 +88,7 @@ Resources:
- Path: !Sub s3://${pStageBucket}/post-stage/${pTeamName}/${pDatasetName}

rGlueCrawlerLakeFormationPermissions:
Condition: UseExistingGlueDatabase
Type: AWS::LakeFormation::Permissions
Properties:
DataLakePrincipal:
Expand All @@ -95,6 +103,7 @@ Resources:

######## SSM #########
rGlueDataCatalogSsm:
Condition: UseExistingGlueDatabase
Type: AWS::SSM::Parameter
Properties:
Name: !Sub /SDLF/Glue/${pTeamName}/${pDatasetName}/DataCatalog
Expand All @@ -103,6 +112,7 @@ Resources:
Description: !Sub "${pTeamName} team ${pDatasetName} metadata catalog"

rGlueCrawlerSsm:
Condition: UseExistingGlueDatabase
Type: AWS::SSM::Parameter
Properties:
Name: !Sub /SDLF/Glue/${pTeamName}/${pDatasetName}/GlueCrawler
Expand Down