Improve error handling for sdlf-stage-lambda/sdlf-stage-glue #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send processing failures to a SQS dead-letter queue (DLQ) visually show processing failures with the post lambda & avoid confusion about where errors happened (due to the parallel state wrapper) to that end: add sqs dead-letter queue url to sdlf-pipeline stack outputs align dlq and queue content dedup configuration send failures to sqs dlq in the distributed map runs collecting failures and sending them to the dlq in the post-processing lambda is not scalable due to sfn output size limits add a message attribute containing the state machine execution id for easier debugging align peh_id and sfn state machine execution name both are uuid4 anyway and this helps debugging and updating the peh dynamodb table remove the error lambda, subsumed entirely by the state machine itself and the post lambda remove the parallel state wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
would close #514 by providing a clearer indication of failure/partial failure
Description of changes:
Improve error handling for
sdlf-stage-lambdaandsdlf-stage-glue:To that end:
The lambda and glue stages are the only one updated in this PR - the others work a bit differently, I plan to align all of them in a future PR. Also this PR is not meant to be a perfect solution, but I'm keeping the changes and the workload manageable...
A couple example screenshots to show what it may look like/the testing done (I've also rerun the workshop to be sure):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.