generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor deployment pipeline and add Elasticsearch observability #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anshrma
wants to merge
7
commits into
main
Choose a base branch
from
feature/refactor-deployment-elasticsearch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anshrma
commented
Nov 11, 2025
- Move Docker image building from app-template-generator to TemplateStorageStack
- Add Elasticsearch-based observability integration with new elastic.py module
- Remove CloudFormation deployment service in favor of unified deployment approach
- Update UI components and configuration models to support new deployment flow
- Enhance stack definitions with force deployment capabilities
- Move Docker image building from app-template-generator to TemplateStorageStack - Add Elasticsearch-based observability integration with new elastic.py module - Remove CloudFormation deployment service in favor of unified deployment approach - Update UI components and configuration models to support new deployment flow - Enhance stack definitions with force deployment capabilities
Add logic to guarantee ManagedBy and AgentName tags are present on CloudFormation stacks during updates, with ManagedBy tag required for proper deletion permissions.
- Remove Langfuse-specific references in favor of generic observability - Add Strands tracer import and configuration for provider-agnostic tracing - Implement automatic Strands SDK observability setup in create_agent() - Update agent execution to handle AgentResult objects and forward metrics - Add error handling for observability configuration failures This enables comprehensive observability across different providers while maintaining backward compatibility.
Implement secure logging utilities to prevent exposure of sensitive credentials in logs. Add three new methods to BaseObservabilityProvider for safe credential validation and endpoint logging that hash or mask sensitive values while preserving debugging capability. Update DatadogObservabilityProvider to use secure logging instead of plain text output for API keys and configuration details.
- Replace print statements with secure logging in Dynatrace provider - Add filtering for sensitive config values in base observability class - Hash non-whitelisted string values to prevent data leakage - Implement secure endpoint and error logging utilities - Refactor trace attributes creation using DRY principles
…urity risks - Replace verbose secure logging methods with minimal validation approach - Remove _log_credentials_securely, _log_endpoint_securely methods - Add _validate_credentials_safely method with reduced logging surface - Update Datadog provider to use simplified credential validation - Reduce potential for sensitive information leakage in logs
…uidance - Add OpenTelemetry environment variables for official Datadog integration - Switch from OTLP intake to official trace agent endpoint - Update headers to use dd-api-key and dd-otlp-source format - Include new OTEL variables in cleanup process - Follow documented best practices from Datadog LLM observability docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.