This repository was archived by the owner on Jun 26, 2025. It is now read-only.
Update build-s3-dist.sh and run-unit-tests.sh to Handle Paths with Spaces#47
Open
adam-intel wants to merge 2 commits intoaws-solutions:mainfrom
Open
Update build-s3-dist.sh and run-unit-tests.sh to Handle Paths with Spaces#47adam-intel wants to merge 2 commits intoaws-solutions:mainfrom
adam-intel wants to merge 2 commits intoaws-solutions:mainfrom
Conversation
Allow build-s3-dist.sh to work when the current working directory has spaces.
Contributor
|
Thanks @adam-intel. These changes seem reasonable, but we will review. We cannot merge these PRs directly, but if this change is accepted, we can incorporate it into a future release. |
Apply the same fix for the run-unit-tests.sh
adam-intel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This update enhances the build script to properly handle paths with spaces. The script now correctly handles directory names that contain spaces by wrapping variables in quotes when they are used in commands.
This change does not alter any functional aspects of the script other than improving its compatibility with directory names containing spaces.
Testing:
The script was tested in environments with and without spaces in directory paths to ensure that it functions correctly in both scenarios.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.