Add support for optional job document fields#115
Merged
kstribrnAmzn merged 5 commits intoaws:mainfrom Feb 24, 2025
Merged
Conversation
FileType (for example) is optional in a job document. If the field exists, parse it. If not, skip it.
Member
Author
|
Expecting memory stats to fail. I'll update this with the new memory footprint after the failure. |
Member
Author
|
Coverage is failing because the C compiler version file created by CMake cannot be found. It's expected in the build directory but has since moved to |
6878b6b to
fc18f29
Compare
24.04 currently includes a newer LCOV verson which is incompatible with our current setup
fc18f29 to
8f45d43
Compare
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
affb13c to
adfa912
Compare
Member
Author
Per the man page this is the same as |
aggarg
approved these changes
Feb 24, 2025
cookpate
approved these changes
Feb 24, 2025
tony-josi-aws
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FileType (for example) is optional in a job document. If the field exists, parse it. If not, skip it.
Testing
Executed updated unit tests per README instructions.
Issue
See #114
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.