generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 238
Agent Health Metric for Windows Events Filtering #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paamicky
wants to merge
2
commits into
main
Choose a base branch
from
AdoptionMetric-windows-event-filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
615200a to
9fb255f
Compare
okankoAMZ
reviewed
Jul 22, 2025
17a0312 to
874edae
Compare
okankoAMZ
previously approved these changes
Jul 23, 2025
sky333999
reviewed
Jul 23, 2025
|
This PR was marked stale due to lack of activity. |
|
This PR was marked stale due to lack of activity. |
the-mann
previously approved these changes
Oct 23, 2025
sky333999
reviewed
Oct 24, 2025
jefchien
reviewed
Oct 24, 2025
Dont use reflect Adds unit tests
282e8d7 to
21104dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently, there is no way to know the number of customers using the windows event filtering in the Agent's configuration. This PR address this issue by adding the feature as part of the user-agent string for detection during API calls to CloudWatch.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit tests added, tests are passing
Filter flags been added to the user-agent input string.
Validated by running CWA on a windows instance, adoption metrics are enabled.
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.