Skip to content

Conversation

agarakan
Copy link
Contributor

@agarakan agarakan commented Aug 20, 2025

Description of the issue

Add Relabel Config to the Prometheus Receiver Translator when ECS Observer is enabled. The purpose of this change is to modify the Prometheus File-based service discovery labels collected by OTel ECS Observer to maintain parity with the existing EcsServicediscovery telegraf plugin

Description of changes

Updates the Prometheus Receiver Translator to append default Relabel Config when ECS Observer is enabled. The config are added to the generated OTEL Yaml file.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Added unit tests for added functionality. updated existing tests for latest behavior

make test
make fmt
make fmt-sh
make lint

See validation of included relabel fields via integration test:
Screenshot 2025-08-27 at 9 29 50 PM

Previous state:

Screenshot 2025-08-27 at 12 13 01 PM

Requirements

Before commiting your code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

Integration Tests

To run integration tests against this PR, add the ready for testing label.

@agarakan agarakan requested a review from a team as a code owner August 20, 2025 19:07
@agarakan agarakan force-pushed the ecs_observer-relabel-config branch from 9c5eea7 to 1d49b37 Compare August 20, 2025 20:12
@agarakan agarakan marked this pull request as draft August 20, 2025 20:46
@agarakan agarakan force-pushed the ecs_observer-relabel-config branch from 6c700a9 to 6f5f999 Compare August 20, 2025 20:50
@agarakan agarakan force-pushed the ecs_observer-relabel-config branch from 6f5f999 to 5af9d0b Compare August 20, 2025 21:02
@agarakan agarakan marked this pull request as ready for review August 20, 2025 21:03
@agarakan agarakan force-pushed the ecs_observer-relabel-config branch from 3b093e0 to 88bc7a6 Compare August 28, 2025 02:47
@agarakan agarakan requested a review from sky333999 August 28, 2025 02:49
@agarakan agarakan force-pushed the ecs_observer-relabel-config branch from 7478250 to 27ca324 Compare September 3, 2025 16:41
@agarakan agarakan merged commit 76b02e4 into replace-telegrapf-prom-plugin Sep 3, 2025
@agarakan agarakan deleted the ecs_observer-relabel-config branch September 3, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants