Skip to content

The build process fails on tests if run as root #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

The build process fails on tests if run as root #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6684c8
Check if ua.inputs is not specified
asklymenko Sep 1, 2025
9c567c0
Check if ua.inputs is empty
asklymenko Sep 1, 2025
bdc11b4
Better formatting
asklymenko Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extension/agenthealth/handler/useragent/useragent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ func (ua *userAgent) SetComponents(otelCfg *otelcol.Config, telegrafCfg *telegra

if !ua.isRoot {
ua.inputs.Add(flagRunAsUser)
} else if len(ua.inputs) == 0 {
ua.inputs.Add(flagRunAsUser)
}

ua.inputsStr.Store(componentsStr(typeInputs, ua.inputs))
Expand Down
9 changes: 9 additions & 0 deletions extension/agenthealth/handler/useragent/useragent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ func TestEmf(t *testing.T) {
},
}
ua := newUserAgent()
if len(ua.inputs) == 0 {
ua.isRoot = false
}
ua.SetComponents(otelCfg, &telegraf.Config{})
assert.Len(t, ua.inputs, 2)
assert.Len(t, ua.processors, 0)
Expand All @@ -154,6 +157,9 @@ func TestMissingEmfExporterConfig(t *testing.T) {
},
}
ua := newUserAgent()
if len(ua.inputs) == 0 {
ua.isRoot = false
}
ua.SetComponents(otelCfg, &telegraf.Config{})
assert.Len(t, ua.inputs, 2)
assert.Len(t, ua.processors, 0)
Expand Down Expand Up @@ -198,6 +204,9 @@ func TestJmx(t *testing.T) {
},
}
ua := newUserAgent()
if len(ua.inputs) == 0 {
ua.isRoot = false
}
ua.SetComponents(otelCfg, &telegraf.Config{})
assert.Len(t, ua.inputs, 5)
assert.Len(t, ua.processors, 0)
Expand Down