Adding unit test for FindReceiversInConfig #1914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramadon
added
the
ready for testing
jefchien
reviewed
Oct 22, 2025
| // This ensures adapter receivers are properly discovered and categorized into their respective pipelines. | ||
| // Only remove this test if the FindReceiversInConfig call is replaced with an alternative mechanism and all | ||
| // downstream tests continue to pass. | ||
| func TestFindReceiversInConfigCalled(t *testing.T) { |
There was a problem hiding this comment.
I'm not sure I understand the purpose of this test. How is it different than the TestTranslators test above it? All of the same test cases are covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Adds
TestFindReceiversInConfigCalledunit test to ensureFindReceiversInConfigis called for metrics configuration in the host pipeline translator.Description of changes
This test validates that adapter receivers (cpu, mem, diskio, net, statsd, etc.) are properly discovered and categorized into their respective pipelines (host, hostCustomMetrics, hostDeltaMetrics). This prevents accidental removal of critical receiver discovery logic.