Fix LocalStack availability for retried PR test jobs #1955
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When users retry failed jobs in GitHub Actions, the
StartLocalStackjob may not be rerun if it previously succeeded, but the test jobs that depend on LocalStack will try to connect to a LocalStack instance that no longer exists.This causes CA bundle tests and other LocalStack-dependent integration tests to fail with connection errors.
Root Cause
https://localhost:4566Solution
Add condition to
StartLocalStackjob:How It Works:
Benefits
✅ Retry-Safe: Test jobs always get a running LocalStack instance
✅ Respects Workflow Logic: Still honors label check on first run
✅ Minimal Change: Single line modification
✅ CA Bundle Tests Fixed: LocalStack will always be available for SSL testing
Testing
This fix ensures that when integration tests are retried, they will have access to a fresh LocalStack instance for testing SSL certificate validation and other AWS service interactions.